Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing a scripted field causes errors #33251 #34679

Merged
merged 4 commits into from
Apr 11, 2019
Merged

Editing a scripted field causes errors #33251 #34679

merged 4 commits into from
Apr 11, 2019

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Apr 7, 2019 •
edited
Loading

Summary

Fix for #33251

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

@lizozom lizozom self-assigned this Apr 7, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@lizozom
Copy link
Contributor Author

lizozom commented Apr 8, 2019

retest

@lizozom lizozom requested a review from lukasolson April 8, 2019 15:54
@lizozom lizozom added :AppArch Team:Visualizations Visualization editors, elastic-charts and infrastructure bug Fixes for quality problems that affect the customer experience v7.2.0 v8.0.0 labels Apr 8, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lizozom lizozom marked this pull request as ready for review April 10, 2019 07:44
@lizozom
Copy link
Contributor Author

lizozom commented Apr 10, 2019

@lukasolson ready for review

lukasolson
lukasolson approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@lukasolson lukasolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in Chrome

@lizozom lizozom merged commit 9f86745 into elastic:master Apr 11, 2019
lizozom added a commit to lizozom/kibana that referenced this pull request Apr 11, 2019
@lizozom
Editing a scripted field causes errors elastic#33251 (elastic#34679)
d7132ca 
* Changed the default fieldFormatMap to undefined - bugfix

* Test for bug elastic#33251

* Remove only
@lizozom lizozom mentioned this pull request Apr 11, 2019
Merged
lizozom added a commit that referenced this pull request Apr 11, 2019
@lizozom
Editing a scripted field causes errors #33251 (#34679) (#34912)
7836db5 
* Changed the default fieldFormatMap to undefined - bugfix

* Test for bug #33251

* Remove only
@lizozom lizozom mentioned this pull request Apr 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasolson lukasolson lukasolson approved these changes

Assignees

@lizozom lizozom

Labels
bug Fixes for quality problems that affect the customer experience release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lizozom @elasticmachine @lukasolson @timroes