Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Controls - Spaces API Docs #34575

Merged
merged 3 commits into from
Apr 17, 2019
Merged

Feature Controls - Spaces API Docs #34575

merged 3 commits into from
Apr 17, 2019

Conversation

legrego
Copy link
Member

@legrego legrego commented Apr 4, 2019 •
edited
Loading

Summary

  • Updates the Spaces API documentation to reflect new "disabledFeatures" property
  • Introduces Features API documentation to assist the Spaces API docs

Related: #31053

@legrego legrego added Team:Docs Feature:Security/Feature Controls Platform Security - Spaces & Role Mgmt feature controls labels Apr 4, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@legrego legrego mentioned this pull request Apr 10, 2019
Closed
6 tasks
@legrego legrego changed the base branch from granular-app-privileges to master April 12, 2019 16:27
@legrego legrego force-pushed the fc/spaces-api-docs branch from 2c0b4e3 to bff836e Compare April 12, 2019 16:28
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@legrego legrego mentioned this pull request Apr 15, 2019
Closed
@legrego legrego marked this pull request as ready for review April 15, 2019 12:26
@legrego legrego requested review from kobelb and gchaps April 15, 2019 12:27
kobelb
kobelb approved these changes Apr 16, 2019
View reviewed changes
docs/api/features.asciidoc Outdated Show resolved Hide resolved
docs/api/spaces-management/get.asciidoc Outdated Show resolved Hide resolved
gchaps
gchaps approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. Otherwise, LGTM.

docs/api/features.asciidoc Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@legrego legrego merged commit 6fdad7f into elastic:master Apr 17, 2019
@legrego legrego deleted the fc/spaces-api-docs branch April 17, 2019 13:02
@legrego legrego mentioned this pull request Apr 17, 2019
Merged
legrego added a commit to legrego/kibana that referenced this pull request Apr 17, 2019
@legrego
Feature Controls - Spaces API Docs (elastic#34575)
d196961 
## Summary

- Updates the Spaces API documentation to reflect new "disabledFeatures" property
- Introduces Features API documentation to assist the Spaces API docs

Related: elastic#31053
legrego added a commit that referenced this pull request Apr 17, 2019
@legrego
[7.x] Feature Controls - Spaces API Docs (#34575) (#35224)
737a9be 
Backports the following commits to 7.x:
 - Feature Controls - Spaces API Docs  (#34575)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps approved these changes

@kobelb kobelb kobelb approved these changes

Assignees
No one assigned
Labels
Feature:Security/Feature Controls Platform Security - Spaces & Role Mgmt feature controls Team:Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legrego @elasticmachine @kobelb @gchaps