Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New platform move error services #34556

Closed

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Apr 4, 2019

Summary

  • Moved error_auto_create_index into saved_objects
  • Moved error_url_overflow into chrome
  • Moved error_allow_explicit_index into courier

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

@lizozom lizozom requested a review from a team as a code owner April 4, 2019 15:21
@stacey-gammon stacey-gammon mentioned this pull request Apr 4, 2019
94 tasks
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@lizozom lizozom requested review from lukeelmers and mattkime April 10, 2019 07:50
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lizozom
Copy link
Contributor Author

lizozom commented Apr 10, 2019

@elastic/kibana-design - no UI changes, just moved code to different folders

@mattkime
Copy link
Contributor

LGTM but we should try to find someone who might understand how this would fail.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@lizozom
Copy link
Contributor Author

lizozom commented Apr 14, 2019

Discarded due to conflicts with core changes

@lizozom lizozom closed this Apr 14, 2019
@lizozom lizozom deleted the new-platform-move-error-services branch April 21, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants