Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] (Accessibility) Import Data -> Index Name should announce as "required" #31130 #34341

Merged
merged 2 commits into from
Apr 2, 2019
Merged

[ML] (Accessibility) Import Data -> Index Name should announce as "required" #31130 #34341

merged 2 commits into from
Apr 2, 2019

Conversation

PhilippBaranovskiy
Copy link
Contributor

Fix: #31130

Summary

I've added translated aria-label for the text input.

@PhilippBaranovskiy PhilippBaranovskiy self-assigned this Apr 2, 2019
@PhilippBaranovskiy PhilippBaranovskiy requested a review from a team as a code owner April 2, 2019 10:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

peteharverson
peteharverson requested changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This edit looks good, but as part of this PR I think we also need to add that same aria-label to the index name field on the advanced page - see the advanced.js file in that same folder.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

peteharverson
peteharverson approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alexwizp
alexwizp approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maryia-lapata
maryia-lapata approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhilippBaranovskiy PhilippBaranovskiy merged commit 5b9cdc7 into elastic:master Apr 2, 2019
@PhilippBaranovskiy PhilippBaranovskiy deleted the 31130 branch April 2, 2019 17:07
@PhilippBaranovskiy PhilippBaranovskiy mentioned this pull request Apr 2, 2019
Merged
PhilippBaranovskiy added a commit to PhilippBaranovskiy/kibana that referenced this pull request Apr 2, 2019
@PhilippBaranovskiy
[ML] (Accessibility) Import Data -> Index Name should announce as "r…
2c8b969 
…equired" elastic#31130  (elastic#34341)

* adds aria label for required index name text input
* translated aria-label for advanced DataVisualizer import settings
PhilippBaranovskiy added a commit that referenced this pull request Apr 2, 2019
@PhilippBaranovskiy
[ML] (Accessibility) Import Data -> Index Name should announce as "r…
ff28223 
…equired" #31130  (#34341) (#34368)

* adds aria label for required index name text input
* translated aria-label for advanced DataVisualizer import settings
@aphelionz aphelionz mentioned this pull request Jul 3, 2019
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@maryia-lapata maryia-lapata maryia-lapata approved these changes

@alexwizp alexwizp alexwizp approved these changes

Assignees

@PhilippBaranovskiy PhilippBaranovskiy

Labels
backported :ml Project:Accessibility release_note:enhancement v7.2.0 WCAG A
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PhilippBaranovskiy @elasticmachine @peteharverson @maryia-lapata @alexwizp