Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds settings section to breaking changes #34328

Merged
merged 2 commits into from
Apr 2, 2019

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Apr 2, 2019

Summary

This PR categorizes the entry in the 8.0 Breaking Changes (https://www.elastic.co/guide/en/kibana/master/breaking-changes-8.0.html) into a "Settings changes" section, so that it matches the layout established in 7.0.

This change also ensure that the info is displayed properly in the Installation and Upgrade Guide. Currently, it's appearing as a peer to the Kibana section in https://www.elastic.co/guide/en/elastic-stack/master/elastic-stack-breaking-changes.html

image

[skip ci]

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs

@schersh schersh self-requested a review April 2, 2019 13:21
Copy link
Contributor

@schersh schersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@lcawl lcawl merged commit d13af85 into elastic:master Apr 2, 2019
@lcawl lcawl deleted the format-breaking-changes branch April 2, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants