[Maps] Prevent console error by not querying for features in non-existing mapbox layers #34321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
added
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis |
thomasneirynck
commented
Apr 1, 2019
| @@ -527,7 +527,7 @@ export class VectorLayer extends AbstractLayer { | |||
| } | |||
|
|
|||
| canShowTooltip() { | |||
| return this._source.canFormatFeatureProperties(); | |||
| return this.isVisible() && this._source.canFormatFeatureProperties(); | |||
There was a problem hiding this comment.
small optimization and unrelated to this bug fix.
This doesn't change the behavior in practice because the corresponding mapbox-layers are turned invisible as well, which would not return any results to begin with.
nreese
approved these changes
Apr 1, 2019
thomasneirynck
added
the
release_note:skip
💚 Build Succeeded |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Apr 2, 2019
…ting mapbox layers (elastic#34321)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34166