[ML] Anomaly Explorer - ensure valid syntax after removing 2nd of 3 filters via icon #34187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
non-issue
alvarezmelissa87
requested review from
walterra,
peteharverson and
jgowdyelastic
|
Pinging @elastic/ml-ui |
💚 Build Succeeded |
There was a problem hiding this comment.
This works for three filters joined with ands, but the same sort of issue occurs when I have three filters linked with ors. Here I have removed the middle filter using the - icon, but an extra or is left in, so I see
rather than
Could this fix be extended to work with the or operator too?
|
@peteharverson - added a fix for the OR operator as well 👍 |
💚 Build Succeeded |
| // If string has a double 'and' operator (e.g. tag:thing and and tag:other) remove as it is illegal kuery syntax | ||
| const invalidAndPattern = /\s+(and)\s+(and)\s+/ig; | ||
| // If string has a double 'or' operator (e.g. tag:thing or or tag:other) remove as it is illegal kuery syntax | ||
| const invalidOrPattern = /\s+(or)\s+(or)\s+/ig; |
There was a problem hiding this comment.
this won't catch OR AND or AND OR.
the regex could be changed to something like /\s+(and|or)\s+(and|or)\s+/ig to catch all combinations of duplicate operators.
💚 Build Succeeded |
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Apr 2, 2019
…ilters via icon (elastic#34187) * Remove middle filter value correctly using icons * remove middle filter value in OR query correctly with icons * combine operator pattern check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix for #33861
When creating filters via filter icons in Anomaly Explorer - if middle filter is removed via icon duplicate
andoperators are left in the filter bar - which is invalid syntax.This PR adds a check for those duplicate operators when removing a filter via icons and removes the duplication. Resulting syntax is valid.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorialsFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately