Fix missing column totals in data table.

[lukeelmers]

Fixes #34046
Regression seems to have been introduced in #28746

The data table relies on isNumeric and isDate params to be defined
on each dimension so that it can determine how to calculate and format
column totals when they are enabled.

These params were missing from the getSchemas utility, causing the
data table to render empty rows for totals.

We have tests to catch this, but they were using mocked data with the
correct params, while the actual code was generating dimensions
without those params.

This is another case we should consider when adding tests for
getSchemas in #33196.

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[ppisljar]

we are adding isDate and isNumber to schema config but:

• this seems to be more related to schema format ?
• this seems to only be needed by table vis ?
• we already have schema.params.date (and now introducing isDate)

[lukeelmers]

Took a more minimal approach per discussion with @ppisljar... The isDate and isNumeric checks now just happen inside the agg_table directive, making them specific to table vis, as other visualizations should not need this info, and we are rewriting table vis eventually anyway.

Kept the getSchemas refactoring in place, but it introduces no functionality changes.

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[ppisljar]

totals don't work for terms aggregation on number field (not sure if that was ever a thing)

apart from that LGTM (tested in chrome linux)

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[lukeelmers]

• 7.x: 0320286
• 7.0: 6108b29

[tzachshabtay]

@lukeelmers We're using 7.1.1 and we don't see the total row, is the fix in that version?

[lukeelmers]

@tzachshabtay Yes, the fix made it to the 7.1 branch so it should be working in 7.1.1

I just tested in 7.1.1, and it seems to be working fine for me: when using a table with split rows on a terms aggregation with the "show totals" option checked, I see the totals as expected.

What type of aggregation are you using where you aren't seeing the totals?

[tzachshabtay]

@lukeelmers we upgraded to 7.2 but it's still not showing.
We're using the data table visualization, split rows on term aggregation as well.
We're using the sum as our "total function".

If we switch to count as our "total function" then it does show, but any other total function doesn't show (and it did show on kibana 6.x).

Some screenshots of our setup:

Here showing that it works with count:

[tzachshabtay]

Seems to be fixed in version 7.3.0.