New platform cleanup autoload - step 2 #33807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 27 commits
March 24, 2019 15:56
- kbn_top_nav
- saved_object_save_as_checkbox
used implicitly: - bound_to_config_obj - debounce - filter_manager - index_patterns - parse_query - persisted_log - timefilter
- css truncate - inequality
- input_focus - paginate
Explicitly included sort_prefix_first filter
Added explicit import to uriescape
lizozom
changed the title
💔 Build Failed |
💚 Build Succeeded |
94 tasks
lizozom
added
Feature:New Platform
Team:Visualizations
|
Pinging @elastic/kibana-app |
💚 Build Succeeded |
lukeelmers
approved these changes
Mar 29, 2019
|
@lukeelmers Thanks! When a files license is changed, git@vscode detects it as a new file. |
lizozom
added a commit
to lizozom/kibana
that referenced
this pull request
Mar 31, 2019
* Explicit dependencies to doc_title
* Explicit dependencies to
- kbn_top_nav
- saved_object_save_as_checkbox
* Explicit dependencies to filter_bar
* Explicit dependency to query_bar
* Removed modules from autoloades that never
used implicitly:
- bound_to_config_obj
- debounce
- filter_manager
- index_patterns
- parse_query
- persisted_log
- timefilter
* Removed modules from autoload (never used implicitly)
- events
* Explicit dependency to bind + typo fix
* Explicit dependency to fancy_forms
* Explicit dependency to $listen
* Explicit dependency to timepicker
* Moved kbn-infinite-scroll directive to doc_table
* Explicit dependency on directives
- css truncate
- inequality
* Explicit dependecy to input_focus directive
* Explicit dependency to json-input directive
* Explicit dependency on directives:
- input_focus
- paginate
* Explicit dependency on paginated-selectable-list directive
* Explicit dependency on saved-object-finder directive
* Moved validate_json directive into agg_types
* Don't include directives implicitly
* Moved comma list
Explicitly included sort_prefix_first filter
* Deleted unused filter unique
* Deleted unused filter startFrom
* Removed unused filter matchAny
* Moved filter trustAsHtml to kbn_doc_views
Added explicit import to uriescape
* Moved markdown filter to notify
* Explicitly import label filter
* Remove implicit autoload of filters
lizozom
added a commit
that referenced
this pull request
Mar 31, 2019
* Explicit dependencies to doc_title
* Explicit dependencies to
- kbn_top_nav
- saved_object_save_as_checkbox
* Explicit dependencies to filter_bar
* Explicit dependency to query_bar
* Removed modules from autoloades that never
used implicitly:
- bound_to_config_obj
- debounce
- filter_manager
- index_patterns
- parse_query
- persisted_log
- timefilter
* Removed modules from autoload (never used implicitly)
- events
* Explicit dependency to bind + typo fix
* Explicit dependency to fancy_forms
* Explicit dependency to $listen
* Explicit dependency to timepicker
* Moved kbn-infinite-scroll directive to doc_table
* Explicit dependency on directives
- css truncate
- inequality
* Explicit dependecy to input_focus directive
* Explicit dependency to json-input directive
* Explicit dependency on directives:
- input_focus
- paginate
* Explicit dependency on paginated-selectable-list directive
* Explicit dependency on saved-object-finder directive
* Moved validate_json directive into agg_types
* Don't include directives implicitly
* Moved comma list
Explicitly included sort_prefix_first filter
* Deleted unused filter unique
* Deleted unused filter startFrom
* Removed unused filter matchAny
* Moved filter trustAsHtml to kbn_doc_views
Added explicit import to uriescape
* Moved markdown filter to notify
* Explicitly import label filter
* Remove implicit autoload of filters
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depends on merging #33765
Explicit import of filters and deletion of unused
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibility