Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[monitoring] only create license check if separate monitoring cluster #33590

Merged
merged 1 commit into from
Mar 22, 2019

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Mar 20, 2019

Currently monitoring will register a new license check on instantiation. In situations where a monitoring cluster is not configured, this duplicates the global license check.

This updates monitoring to register a new license check only when there's a separate cluster, otherwise it subscribes to the global check.

@jbudz jbudz added review Team:Monitoring Stack Monitoring team labels Mar 20, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Code changes make sense and I tested functionality both ways and didn't notice any issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants