Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove segmented fetch #33453

Merged
merged 3 commits into from
Mar 27, 2019
Merged

Remove segmented fetch #33453

merged 3 commits into from
Mar 27, 2019

Conversation

lukasolson
Copy link
Member

Replaces #16324.

From the original PR:

Segmented Request was only being used in Discover. It was only actually segmenting requests for old interval based index patterns (and not even for these index patterns in Dashboard). Interval based index patterns are deprecated (cannot be created in 6.0) and will be completely removed in 7.0. The fact that interval based patterns got segmented was an implementation detail of Kibana that is no longer necessary now that ES is smart enough to quickly skip shards that won't return results. The segmented request code creates a huge maintenance burden that prevents us from easily implementing highly requested features like multi-field sorting. This also makes the search fetching behavior more consistent between Discover and Dashboard (which actually relies on the doc table making requests), which will make it easier to extract that logic into a reusable service when we want to rewrite the doc table in React and remove its dependence on Courier.

@lukasolson lukasolson added Feature:Search Querying infrastructure in Kibana Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.2.0 labels Mar 18, 2019
@lukasolson lukasolson self-assigned this Mar 18, 2019
@lukasolson lukasolson requested a review from Bargs March 18, 2019 21:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@lukasolson lukasolson mentioned this pull request Mar 18, 2019
Closed
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@lukasolson lukasolson force-pushed the removeSegmentedFetch branch from 756524a to bec23fc Compare March 18, 2019 23:23
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lukasolson lukasolson mentioned this pull request Mar 19, 2019
Closed
Bargs
Bargs approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@Bargs Bargs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functionality looks good. Inspector and vis are working now, which as far as I can remember were the two last hurdles when I left off. Tested with an old interval based pattern to ensure it still worked and it did. LGTM!

Thanks for taking this across the finish line @lukasolson

@lukasolson lukasolson force-pushed the removeSegmentedFetch branch from bec23fc to 60b16bc Compare March 25, 2019 20:51
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lukasolson lukasolson force-pushed the removeSegmentedFetch branch from 60b16bc to 0b9d909 Compare March 26, 2019 20:45
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lukasolson lukasolson merged commit a848840 into elastic:master Mar 27, 2019
lukasolson added a commit to lukasolson/kibana that referenced this pull request Mar 27, 2019
@lukasolson
Remove segmented fetch (elastic#33453)
002fc5e 
* Remove segmented fetch

* Fix namespace

* Remove unused translations
@lukasolson
Copy link
Member Author

7.x (7.1.0): 002fc5e

joelgriffith pushed a commit that referenced this pull request Mar 27, 2019
@lukasolson
Remove segmented fetch (#33453)
f43ad9f 
* Remove segmented fetch

* Fix namespace

* Remove unused translations
@timroes timroes added the chore label Apr 3, 2019
@Bargs Bargs mentioned this pull request Jul 24, 2019
Merged
3 tasks
@lukasolson lukasolson deleted the removeSegmentedFetch branch December 2, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bargs Bargs Bargs approved these changes

Assignees

@lukasolson lukasolson

Labels
chore Feature:Discover Discover Application Feature:Search Querying infrastructure in Kibana Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukasolson @elasticmachine @Bargs @timroes