[7.0] [Canvas] Simplified aero state (#32980) #33345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Chore: Remove disused shapeAdditions * Refactor: Move configuration into the scene * Chore: Remove disused dispatch * Refactor: move out DOM helper not coupled with layout functions * Chore: make node id generation idempotent * Refactor: Remove selectReduce * Refactor: code alignment with data flow (selector hierarchy) * Refactor: reduced API surface area * Refactor: trivially split state.js * Refactor: simplify `select` * Refactor: extract out workpadPage components * Refactor: rename dag_start * Chore: make todo more salient * Fix: remove chance of collision (two subsequent large random integers may equal) * Chore: split the two captured variables to their own `let`
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.0: