Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleted unused svg icons #33262

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Mar 14, 2019

Summary

Deleted unused SVG icons

icons/beats-color.svg
icons/beats-gray.svg
icons/elasticsearch-color.svg
icons/elasticsearch-gray.svg
icons/kibana-color.svg
icons/kibana-gray.svg
icons/logstash-color.svg
icons/logstash-gray.svg
icons/security-gray.svg

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

@lizozom lizozom added Feature:New Platform Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 labels Mar 14, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@lizozom lizozom self-assigned this Mar 14, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lukeelmers
Copy link
Member

@elastic/kibana-design Do y’all know anything about these seemingly unused icons?

@lukeelmers lukeelmers requested a review from a team March 14, 2019 19:16
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but would like to make sure someone from the design team takes a quick look at it too.

@cchaos
Copy link
Contributor

cchaos commented Mar 14, 2019

If @lizozom can't find any uses of these, I'm happy to remove them. They're old versions anyway.

@lizozom lizozom merged commit 1150217 into elastic:master Mar 14, 2019
@lizozom lizozom added the v7.2.0 label Mar 18, 2019
lizozom added a commit to lizozom/kibana that referenced this pull request Mar 18, 2019
lizozom added a commit that referenced this pull request Mar 18, 2019
@stacey-gammon stacey-gammon mentioned this pull request Mar 20, 2019
94 tasks
@timroes timroes added the chore label Mar 27, 2019
@lizozom lizozom deleted the new-platform-delete-icons branch April 21, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:New Platform Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants