[Code] fixed some type errors

src/dev/build/tasks/patch_native_modules_task.js

@@ -19,7 +19,7 @@
 
 import { scanCopy, untar, deleteAll } from '../lib';
 import { createWriteStream } from 'fs';
-import binaryInfo from '../../../../x-pack/plugins/code/tasks/nodegit_info';
+import { binaryInfo } from '../../../../x-pack/plugins/code/tasks/nodegit_info';
 import wreck from 'wreck';
 import mkdirp from 'mkdirp';
 import { dirname, join, basename } from 'path';
@@ -61,9 +61,8 @@ async function downloadAndExtractTarball(url, dest, log, retry) {
 async function patchNodeGit(config, log, build, platform) {
   const plat = platform.isWindows() ? 'win32' : platform.getName();
   const arch = platform.getNodeArch().split('-')[1];
-  const info = binaryInfo(plat, arch);
-  const downloadUrl = info.hosted_tarball;
-  const packageName = info.package_name;
+  const { downloadUrl, packageName } = binaryInfo(plat, arch);
+
   const downloadPath =   build.resolvePathForPlatform(platform, '.nodegit_binaries', packageName);
   const extractDir = await downloadAndExtractTarball(downloadUrl, downloadPath, log, 3);
 

x-pack/plugins/code/public/components/admin_page/language_server_tab.tsx

@@ -180,13 +180,13 @@ const LanguageServerInstruction = (props: {
         <EuiText grow={false}>
           <h3>Install</h3>
           <p>
-            Stop your kibana Code node, then use the following command to install ${props.name}{' '}
+            Stop your kibana Code node, then use the following command to install {props.name}{' '}
             Language Server plugin:
             <EuiCodeBlock language="shell">{installCode}</EuiCodeBlock>
           </p>
           <h3>Uninstall</h3>
           <p>
-            Stop your kibana Code node, then use the following command to remove ${props.name}{' '}
+            Stop your kibana Code node, then use the following command to remove {props.name}{' '}
             Language Server plugin:
             <pre>
               <code>bin/kibana-plugin remove {props.pluginName}</code>

x-pack/plugins/code/public/components/main/content.tsx

@@ -156,7 +156,7 @@ class CodeContent extends React.PureComponent<Props> {
   };
 
   public renderButtons = () => {
-    let buttonId = null;
+    let buttonId: string | undefined;
     switch (this.props.match.params.pathType) {
       case PathTypes.blame:
         buttonId = ButtonOption.Blame;

x-pack/plugins/code/public/components/search_page/side_bar.tsx

@@ -57,6 +57,9 @@ export class SideBar extends React.PureComponent<Props> {
             onClick={this.props.onRepositoryFilterToggled(item.name)}
             quantity={item.value}
             isSelected={true}
+            buttonRef={() => {
+              /* nothing */
+            }}
           >
             {RepositoryUtils.repoNameFromUri(item.name)}
           </FacetItem>
@@ -67,6 +70,9 @@ export class SideBar extends React.PureComponent<Props> {
             key={`repostats${index}`}
             onClick={this.props.onRepositoryFilterToggled(item.name)}
             quantity={item.value}
+            buttonRef={() => {
+              /* nothing */
+            }}
           >
             {RepositoryUtils.repoNameFromUri(item.name)}
           </FacetItem>
@@ -83,6 +89,9 @@ export class SideBar extends React.PureComponent<Props> {
             quantity={item.value}
             isSelected={true}
             data-test-subj="codeSearchLanguageFilterItem"
+            buttonRef={() => {
+              /* nothing */
+            }}
           >
             {item.name}
           </FacetItem>
@@ -94,6 +103,9 @@ export class SideBar extends React.PureComponent<Props> {
             onClick={this.props.onLanguageFilterToggled(item.name)}
             quantity={item.value}
             data-test-subj="codeSearchLanguageFilterItem"
+            buttonRef={() => {
+              /* nothing */
+            }}
           >
             {item.name}
           </FacetItem>

x-pack/plugins/code/public/monaco/monaco.ts

@@ -3,7 +3,6 @@
  * or more contributor license agreements. Licensed under the Elastic License;
  * you may not use this file except in compliance with the Elastic License.
  */
-import convert from 'color-convert';
 // (1) Desired editor features:
 import 'monaco-editor/esm/vs/editor/browser/controller/coreCommands.js';
 import 'monaco-editor/esm/vs/editor/browser/widget/codeEditorWidget.js';

x-pack/plugins/code/tasks/nodegit_info.ts

@@ -0,0 +1,17 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+// @ts-ignore
+import binary_info from '@elastic/nodegit/dist/utils/binary_info';
+
+export function binaryInfo(platform: string, arch: string) {
+  const info = binary_info(platform, arch);
+  const downloadUrl = info.hosted_tarball;
+  const packageName = info.package_name;
+  return {
+    downloadUrl,
+    packageName,
+  };
+}