You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shared core/types directory cannot depend on core/public or core/server code or our TypeScript builds for production builds will conflict with one another (an issue that may be resolved by upgrading to Babel 7 w/ TS Support)
Additionally, the config service in new platform depends on legacy/util/package_json which is causing problems with conflicting TypeScript outputs in some PRs for core. This module does almost nothing, so this PR removes the dependency on it completely which also fixed the TS build issues.
joshdover
changed the title
Remove dependency on legacy package_json util from core
Remove dependencies on server and browser code in core/types
Mar 6, 2019
The core issue here is that for production builds, we build TS code for the server (tsconfig.json) as commonjs modules and for the browser (tsconfig.browser.json) as esmodules. If a module is imported by both the server and client-side builds, then the client-side build wins and the file is outputted as an esmodule, which Node cannot read.
In order to support TS code sharing (or even just type sharing) between server and browser code, we need to be outputting to a format that both Node and Webpack can read. In my testing it seems that outputting to CommonJS modules works for both environments. If there are no other issues with this approach, then this PR is unnecessary and we can simply change tsconfig.browser.json to remove the module format override.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
joshdover
added
Team:Core
Summary
The shared
core/typesdirectory cannot depend oncore/publicorcore/servercode or our TypeScript builds for production builds will conflict with one another (an issue that may be resolved by upgrading to Babel 7 w/ TS Support)Additionally, the config service in new platform depends on
legacy/util/package_jsonwhich is causing problems with conflicting TypeScript outputs in some PRs for core. This module does almost nothing, so this PR removes the dependency on it completely which also fixed the TS build issues.