Reenable auth provider tests #32565
Merged
Reenable auth provider tests #32565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobelb
added
the
Team:Security
|
Pinging @elastic/kibana-security |
|
I don't know if we need to test in Kibana that refresh tokens can't be used after 60 seconds. We have no control at all over that behavior, and we should be able to assume that Elasticsearch has tests on its own features. If we have unit tests in place for the expected behavior when refresh fails and the expected behavior when an unknown error response is encountered, that should be pretty solid coverage. Your call though. |
|
@epixa I was torn on this as well and almost didn't add them. I'll go ahead and remove them. |
💚 Build Succeeded |
💚 Build Succeeded |
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Mar 6, 2019
* Reenabling token auth provider test * Re-enabling saml test * Adding a SAML test to ensure we can't reuse refresh token after 60 seconds * Adding token auth provider re-use refresh token after 60 seconds test * Removing the reusuing refresh tokens after timeout
PhilippBaranovskiy
pushed a commit
to PhilippBaranovskiy/kibana
that referenced
this pull request
Mar 7, 2019
* Reenabling token auth provider test * Re-enabling saml test * Adding a SAML test to ensure we can't reuse refresh token after 60 seconds * Adding token auth provider re-use refresh token after 60 seconds test * Removing the reusuing refresh tokens after timeout
kobelb
added a commit
that referenced
this pull request
Mar 7, 2019
* Reenabling token auth provider test * Re-enabling saml test * Adding a SAML test to ensure we can't reuse refresh token after 60 seconds * Adding token auth provider re-use refresh token after 60 seconds test * Removing the reusuing refresh tokens after timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the huge improvements which elastic/elasticsearch#39631 gives us, we had to temporarily skip some of our tests. This PR re-enables the tests to assert the new behavior.
Refresh tokens can now be re-used for up to 60 seconds, and they'll return the same access/refresh token as before. These access/refresh tokens are encrypted within the session cookie, and the tests don't attempt to decrypt the cookie to ensure that the auth/refresh tokens are the same, but instead ensure that both continue working to authenticate subsequent requests.
The time limit for reusing refresh tokens is hard-coded at 60 seconds, and as such makes us have some rather long-running tests to ensure that we can't reuse refresh tokens after this window. It bothers me that we have to introduce tests that end up taking right over 85 seconds to execute, but I'd prefer to have the coverage.Resolves: #26744