Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Incorrect behavior when filling the 'interval' field with values: s,m,d,M,y #32542

Merged
merged 3 commits into from
Mar 7, 2019
Merged

[TSVB] Incorrect behavior when filling the 'interval' field with values: s,m,d,M,y #32542

merged 3 commits into from
Mar 7, 2019

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Mar 6, 2019

Fix :#32394

Summary

RegExp patterns for GTE_INTERVAL_RE, INTERVAL_STRING_RE intervals were updated

Checklist

For maintainers

@elasticmachine
Copy link
Contributor

💔 Build Failed

@alexwizp
Copy link
Contributor Author

alexwizp commented Mar 6, 2019

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

timroes
timroes approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@alexwizp
Copy link
Contributor Author

alexwizp commented Mar 6, 2019

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@alexwizp alexwizp merged commit 994cc6c into elastic:master Mar 7, 2019
alexwizp added a commit to alexwizp/kibana that referenced this pull request Mar 7, 2019
@alexwizp
[TSVB] Incorrect behavior when filling the 'interval' field with valu…
011014a 
…es: s,m,d,M,y (elastic#32542)
@alexwizp alexwizp mentioned this pull request Mar 7, 2019
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Mar 7, 2019
@alexwizp
[TSVB] Incorrect behavior when filling the 'interval' field with valu…
ddcfc1e 
…es: s,m,d,M,y (elastic#32542)
@alexwizp alexwizp mentioned this pull request Mar 7, 2019
Merged
alexwizp added a commit that referenced this pull request Mar 7, 2019
@alexwizp
[TSVB] Incorrect behavior when filling the 'interval' field with valu…
fb682e7 
…es: s,m,d,M,y (#32542) (#32622)
PhilippBaranovskiy pushed a commit to PhilippBaranovskiy/kibana that referenced this pull request Mar 7, 2019
@alexwizp @PhilippBaranovskiy
[TSVB] Incorrect behavior when filling the 'interval' field with valu…
3ad1c09 
…es: s,m,d,M,y (elastic#32542)
alexwizp added a commit that referenced this pull request Mar 7, 2019
@alexwizp
[TSVB] Incorrect behavior when filling the 'interval' field with valu…
703247b 
…es: s,m,d,M,y (#32542) (#32621)
@alexwizp alexwizp deleted the 32394 branch January 4, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

@markov00 markov00 Awaiting requested review from markov00

@flash1293 flash1293 Awaiting requested review from flash1293

@sulemanof sulemanof Awaiting requested review from sulemanof

Assignees
No one assigned
Labels
Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexwizp @elasticmachine @timroes