-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chromedriver] use cache from packer if available and current #32511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retest |
💚 Build Succeeded |
https://kibana-ci.elastic.co/job/elastic+kibana+pull-request/3740/JOB=kibana-intake,node=immutable/
✅ |
This reverts commit ac25311.
💚 Build Succeeded |
This reverts commit caf8b09.
💔 Build Failed |
retest |
💚 Build Succeeded |
timroes
added
the
release_note:skip
Skip the PR/issue when compiling release notes
label
Apr 26, 2021
kibanamachine
added
the
backport missing
Added to PRs automatically when the are determined to be missing a backport.
label
Apr 28, 2021
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
removed
the
backport missing
Added to PRs automatically when the are determined to be missing a backport.
label
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
test
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen a number of chromedriver download failures on tracked branches, and I'm assuming they're even more common in PRs, but I had to revert my previous attempt to cache the chromedriver download because I didn't actually test it. This time I've committed the updated packer cache script, I'm running an update to the packer images now, and will test the new images with this updated setup script before merging into the repo 😄