[New platform]Expose NP core services to the legacy UI #32480
Conversation
There was a problem hiding this comment.
Good stuff. One thing though: while stop doesn’t seem necessary, I think we will be adding a separate init lifecycle event alongside start, and both of those contracts will be relevant to legacy plugins.
This isn’t 100% final yet, but perhaps it is worth identifying these apis as “start” so folks don’t need to update their code as much when init happens.
| throw new Error('New platform api was already initialized'); | ||
| } | ||
|
|
||
| runtimeContext.core = Object.freeze(core); |
There was a problem hiding this comment.
I found several deepFreeze implementation in our code base. Should we have a dedicated package/wheterver for this?
💚 Build Succeeded |
mshustov
changed the title
mshustov
force-pushed
the
issue-32395-client-side
branch
from
196b20e to
1dccd0c
Compare
💚 Build Succeeded |
|
@epixa should we add integration tests here? We can test only getter logic, which is not really useful. |
|
@restrry I don't think we should integration test the ui module shims |
mshustov
added
review
Team:Core
|
Pinging @elastic/kibana-platform |
| chrome: ChromeStart; | ||
| } | ||
|
|
||
| interface RuntimeContext { |
There was a problem hiding this comment.
question: Is the whole reason we need this interface because of the conditional existence of start.core?
There was a problem hiding this comment.
yes. as an alternative we can cast type right in place.
const runtimeContext = {
start: {
core: null as StartCore | null,
💔 Build Failed |
💚 Build Succeeded |
* Expose NP core services to the legacy UI * declare start/stop explicitly * simplify typings + renaming
epixa
added
the
release_note:plugin_api_changes
💔 Build Failed |
💔 Build Failed |
Summary
#32395
Expose NP core services to the legacy UI platform. There are no plugins to include yet.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriatelyDev Docs
Expose NP core services to the legacy UI
Kibana is in process of stabilising of API. The client side core services are quite different from existing ones and were heavily refactored. If you want to play around with experimental API use
where
newPlatformexposes: