Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Time picker quick ranges description #32455

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Mar 5, 2019

Summary

With #29204 we replaced the old timepicker by the new timepicker. While that the section part of the quick time ranges has been removed. This PR fixes the description of the corresponding advanced setting to remove that section key.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@timroes timroes added v7.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.2.0 labels Mar 5, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timroes timroes merged commit 51e2629 into elastic:master Mar 5, 2019
@timroes timroes deleted the setting-update branch March 5, 2019 12:27
timroes added a commit to timroes/kibana that referenced this pull request Mar 5, 2019
timroes added a commit to timroes/kibana that referenced this pull request Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants