Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[logstash/pipelineCreate] retry reading rows #32436

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Mar 4, 2019

Fixes #32425

As seen in #32425, the pipeline table can sometimes be done loading but still not have the rows rendered. This seems to be the reason why readRows() returns an empty array sometimes even when the screenshot shows the table fully populated.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger
Copy link
Contributor Author

spalger commented Mar 4, 2019

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger
Copy link
Contributor Author

spalger commented Mar 5, 2019

retest

Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I didn't pull this PR and run it but the change is our standard way to fix this type of loading timing issues and Jenkins likes it :-)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger
Copy link
Contributor Author

spalger commented Mar 5, 2019

7.x/7.1: e6c6a59
7.0: d7f95fe

@spalger spalger deleted the fix/32425 branch March 5, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants