Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra UI] Only calculate the waffle map layout once the width and height are set #32432

Closed
wants to merge 1 commit into from

Conversation

simianhacker
Copy link
Member

@simianhacker simianhacker commented Mar 4, 2019

Summary

This PR attempts to fix the "Waffle Map Shake" by only calculating the layout once. Otherwise as elements are added to the DOM the container expands and with each expansion of the container the sizes are recalculated. There are situations where the width/height are on the cusp and it get's stuck in a loop flipping from one dimension to the other.

Fixes #34235
Fixes #27500
Fixes #34248

image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@simianhacker simianhacker added the Feature:Metrics UI Metrics UI feature label Apr 8, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/infrastructure-ui

@simianhacker simianhacker self-assigned this Apr 23, 2019
@simianhacker simianhacker changed the title Fixes 27500 - Only calculate the waffle map layout once the width and… [Infra UI] Only calculate the waffle map layout once the width and height are set Apr 24, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@simianhacker
Copy link
Member Author

simianhacker commented May 20, 2019

This is no longer relevant

@zube zube bot reopened this May 20, 2019
@zube zube bot closed this May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Metrics UI Metrics UI feature
Projects
None yet
5 participants