Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types to run_pipeline. #32378

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Add types to run_pipeline. #32378

merged 1 commit into from
Mar 4, 2019

Conversation

lukeelmers
Copy link
Member

A small update that tightens up the typings in runPipeline

@lukeelmers lukeelmers added review Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 4, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@lukeelmers lukeelmers requested a review from ppisljar March 4, 2019 04:55
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

ppisljar
ppisljar approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@lukeelmers lukeelmers merged commit 66fb400 into elastic:master Mar 4, 2019
@lukeelmers lukeelmers deleted the fix/runpipeline-types branch March 4, 2019 21:53
@lukeelmers lukeelmers mentioned this pull request Mar 4, 2019
Merged
lukeelmers added a commit to lukeelmers/kibana that referenced this pull request Mar 4, 2019
@lukeelmers
Expressions: Add types to run_pipeline. (elastic#32378)
178671f
lukeelmers added a commit that referenced this pull request Mar 4, 2019
@lukeelmers
Expressions: Add types to run_pipeline. (#32378) (#32427)
d0069e1
@timroes timroes added the chore label Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

Assignees
No one assigned
Labels
chore Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) review Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukeelmers @elasticmachine @ppisljar @timroes