Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude /html_docs from eslint #32314

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Exclude /html_docs from eslint #32314

merged 1 commit into from
Mar 1, 2019

Conversation

mikecote
Copy link
Contributor

@mikecote mikecote commented Mar 1, 2019

This PR excludes /html_docs from eslint. This also fixes other failures eslint has on master.

Steps to reproduce eslint scanning html_docs:

  1. node scripts/docs
  2. node scripts/eslint

@mikecote mikecote self-assigned this Mar 1, 2019
chrisdavies
chrisdavies approved these changes Mar 1, 2019
View reviewed changes
Copy link
Contributor

@chrisdavies chrisdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM make it so

packages/kbn-interpreter/src/public/batched_fetch.test.js
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mikecote mikecote merged commit 8ac6d69 into elastic:master Mar 1, 2019
@mikecote mikecote mentioned this pull request Mar 1, 2019
Closed
chrisdavies pushed a commit to chrisdavies/kibana that referenced this pull request Mar 1, 2019
@mikecote @chrisdavies
Exclude /html_docs from eslint (elastic#32314)
7d86a97
@mikecote mikecote added the non-issue Indicates to automation that a pull request should not appear in the release notes label Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdavies chrisdavies chrisdavies approved these changes

Assignees

@mikecote mikecote

Labels
non-issue Indicates to automation that a pull request should not appear in the release notes review v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikecote @elasticmachine @chrisdavies