Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[types removal] Remove type doc from fetch.js #32288

Merged
merged 1 commit into from
Mar 5, 2019
Merged

[types removal] Remove type doc from fetch.js #32288

merged 1 commit into from
Mar 5, 2019

Conversation

sulemanof
Copy link
Contributor

Summary

This removse type doc from fetch.js in legacy/kibana/server folder

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@alexwizp
Copy link
Contributor

alexwizp commented Mar 1, 2019

Code LGTM

@epixa epixa requested a review from a team March 4, 2019 14:47
@epixa epixa added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Mar 4, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

mikecote
mikecote approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

lukasolson
lukasolson approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@lukasolson lukasolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality & code LGTM

@sulemanof sulemanof merged commit 52e7223 into elastic:master Mar 5, 2019
@sulemanof sulemanof deleted the deprecations/kibana-server branch March 5, 2019 08:00
@sulemanof sulemanof mentioned this pull request Mar 5, 2019
Merged
sulemanof added a commit to sulemanof/kibana that referenced this pull request Mar 5, 2019
@sulemanof
[types removal] Remove type doc from fetch.js (elastic#32288)
c616d19
sulemanof added a commit to sulemanof/kibana that referenced this pull request Mar 5, 2019
@sulemanof
[types removal] Remove type doc from fetch.js (elastic#32288)
fcd2200
@sulemanof sulemanof mentioned this pull request Mar 5, 2019
Merged
sulemanof added a commit that referenced this pull request Mar 5, 2019
@sulemanof
[types removal] Remove type doc from fetch.js (#32288) (#32453)
34fa434
sulemanof added a commit that referenced this pull request Mar 6, 2019
@sulemanof
[types removal] Remove type doc from fetch.js (#32288) (#32454)
1173dfa
@alexwizp alexwizp added the release_note:skip Skip the PR/issue when compiling release notes label Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwizp alexwizp alexwizp approved these changes

@mikecote mikecote mikecote approved these changes

@lukasolson lukasolson lukasolson approved these changes

@jakelandis jakelandis Awaiting requested review from jakelandis

@epixa epixa Awaiting requested review from epixa

@azasypkin azasypkin Awaiting requested review from azasypkin

@joshdover joshdover Awaiting requested review from joshdover

Assignees
No one assigned
Labels
deprecation_warnings release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sulemanof @elasticmachine @alexwizp @lukasolson @mikecote @epixa