Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[types removal] Remove types from saved_objecs repository #32286

Merged
merged 1 commit into from
Mar 5, 2019
Merged

[types removal] Remove types from saved_objecs repository #32286

merged 1 commit into from
Mar 5, 2019

Conversation

sulemanof
Copy link
Contributor

Summary

This removes the usage of types from legacy/saved_objects repository.js file and updates unit tests

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@alexwizp alexwizp requested review from azasypkin and mikecote March 1, 2019 14:08
@azasypkin azasypkin removed their request for review March 1, 2019 14:16
@alexwizp alexwizp requested a review from joshdover March 1, 2019 14:35
@epixa epixa added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Mar 4, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

mikecote
mikecote approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tylersmalley
Copy link
Contributor

Looks like a duplicate of #30452, which includes a few additional locations. The changes here LGTM if we would like to move forward here.

@sulemanof sulemanof merged commit 92559ee into elastic:master Mar 5, 2019
@sulemanof sulemanof deleted the deprecations/saved_objects branch March 5, 2019 08:50
sulemanof added a commit to sulemanof/kibana that referenced this pull request Mar 5, 2019
@sulemanof
[types removal] Remove types from saved_objecs repository (elastic#32286
897b31a 
)
@sulemanof sulemanof mentioned this pull request Mar 5, 2019
Merged
sulemanof added a commit to sulemanof/kibana that referenced this pull request Mar 5, 2019
@sulemanof
[types removal] Remove types from saved_objecs repository (elastic#32286
5ba0b09 
)
@sulemanof sulemanof mentioned this pull request Mar 5, 2019
Merged
sulemanof added a commit that referenced this pull request Mar 5, 2019
@sulemanof
[types removal] Remove types from saved_objecs repository (#32286) (#…
144bac7 
…32456)
sulemanof added a commit that referenced this pull request Mar 6, 2019
@sulemanof
[types removal] Remove types from saved_objecs repository (#32286) (#…
e3549e6 
…32457)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwizp alexwizp alexwizp approved these changes

@mikecote mikecote mikecote approved these changes

@jakelandis jakelandis Awaiting requested review from jakelandis

@epixa epixa Awaiting requested review from epixa

@joshdover joshdover Awaiting requested review from joshdover

Assignees
No one assigned
Labels
deprecation_warnings release_note:fix Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sulemanof @elasticmachine @tylersmalley @mikecote @alexwizp @epixa @rayafratkina