Fix X-Pack JUnit output dir #32256
Merged
Fix X-Pack JUnit output dir #32256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
spalger
force-pushed
the
fix/x-pack-junit-dir
branch
from
16ccfb6 to
d8e0e62
Compare
💚 Build Succeeded |
jbudz
approved these changes
Mar 1, 2019
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Mar 1, 2019
This was referenced Mar 1, 2019
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Mar 1, 2019
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Mar 1, 2019
# Conflicts: # src/functional_test_runner/lib/config/schema.ts
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Mar 1, 2019
# Conflicts: # src/functional_test_runner/lib/config/schema.ts
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Mar 1, 2019
# Conflicts: # src/functional_test_runner/lib/config/schema.ts # x-pack/test/functional/config.js
spalger
pushed a commit
that referenced
this pull request
Mar 2, 2019
spalger
pushed a commit
that referenced
this pull request
Mar 2, 2019
spalger
pushed a commit
that referenced
this pull request
Mar 2, 2019
spalger
pushed a commit
that referenced
this pull request
Mar 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The X-Pack tests are currently being configured with a
junit.rootDirectoryof{abs}/x-packin most cases, which removes the prefix from paths in the reports but is also causes the reports to be written tox-pack/target/.... This means we have junit reports in multiple locations which breaks our automation to create issues for failed tests. This removes the configuration from where it was used, keeping it as an option in the classes themselves so they can be tested in sub directories.