Show the filter bar in dashboard embed mode #32222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bargs
added
Feature:Filters
v7.0.0
Team:Visualizations
|
Pinging @elastic/kibana-app |
💚 Build Succeeded |
lukasolson
approved these changes
Mar 1, 2019
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Mar 1, 2019
Bargs
added a commit
that referenced
this pull request
Mar 4, 2019
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Mar 4, 2019
Bargs
added a commit
that referenced
this pull request
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #31880
The old filter bar lived outside the top nav, which is hidden in embed mode. Now that the filter bar is combined with the query bar in the top nav it is also hidden in embed mode. This PR adds a second standalone filter bar that is only added to the page in embed mode. I took this same approach to fix the same issue in Visualize.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately