[APM] Update contextual data objects and sorting for ECS #32199
Conversation
|
Pinging @elastic/apm-ui |
💔 Build Failed |
|
@elastic/apm-ui Would be great to have someone go over the open todo's when time permits. I would like to power through and get these changes in ASAP. As some existing data objects have been missing entirely from displaying in UI (i.e. Custom), I feel like we can mark this as a regression and bug for 7.0. Thoughts? |
The agent is moved its own object.
💔 Build Failed |
|
@formgeist I'll take a look at the remaining TODOs. |
|
@sqren Merci 👍 |
|
@formgeist Take a look when you have time and LMK if there is anything missing |
💔 Build Failed |
|
@sqren Great work, and thanks for sorting out the remaining tasks. I've made some visual tweaks to the table. Bumped the fontsize and decreased the first column fixed width so there's more space for that 3rd column in HTTP. |
|
The flyout size will be increased in #32021 so I think it'll all come together nicely in the end. |
💔 Build Failed |
💚 Build Succeeded |
The agent is moved its own object.
sorenlouv
force-pushed
the
apm-update-context-info
branch
from
d7599bb to
95a30c1
Compare
On second thought, the fontsize was too large. Now matches Discover.
… into apm-update-context-info
|
On second thought, I changed the fontsize back its original size. It was too large, and now it matches the general code fontsize in i.e. Discover. |
💚 Build Succeeded |
|
@formgeist The other thing ended up in some bigger changes, so if you are okay with this as-is I'll merge that and then create a separate PR for the other. |
|
SGTM, let's merge it |
|
@alvarolobato @makwarth @roncohen Should we consider backporting this to 7.0? Please see my comment above. |
|
makes sense to me @formgeist 👍 |
* Reordering existing data and adding new ECS fields. * Removed agent The agent is moved its own object. * Support 3rd level properties * Add support for nested properties like `error.custom` and `transaction.custom` * Bumped fontsize * Decreased first column min-width * Updated snapshot * Update tests * Fixed translation label * Reordering existing data and adding new ECS fields. * Removed agent The agent is moved its own object. * Support 3rd level properties * Add support for nested properties like `error.custom` and `transaction.custom` * Bumped fontsize * Decreased first column min-width * Updated snapshot * Update tests * Fixed translation label * Decreased fontsize On second thought, the fontsize was too large. Now matches Discover.
… (#32553) * [APM] Update contextual data objects and sorting for ECS (#32199) * Reordering existing data and adding new ECS fields. * Removed agent The agent is moved its own object. * Support 3rd level properties * Add support for nested properties like `error.custom` and `transaction.custom` * Bumped fontsize * Decreased first column min-width * Updated snapshot * Update tests * Fixed translation label * Reordering existing data and adding new ECS fields. * Removed agent The agent is moved its own object. * Support 3rd level properties * Add support for nested properties like `error.custom` and `transaction.custom` * Bumped fontsize * Decreased first column min-width * Updated snapshot * Update tests * Fixed translation label * Decreased fontsize On second thought, the fontsize was too large. Now matches Discover. * Fix types
|
This made it into 7.0 👍 |
Summary
Fixes #30069
agent.*,container.*andtransaction.customobjectsURLerror.customfor Error occurrence details properties.