Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Adds missing applyAsync to advanced job wizard page #32186

Merged
merged 1 commit into from
Mar 1, 2019
Merged

[ML] Adds missing applyAsync to advanced job wizard page #32186

merged 1 commit into from
Mar 1, 2019

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Feb 28, 2019 •
edited
Loading

Summary

Adds a missing $scope.$applyAsync() call to the Advanced job wizard page, for the check for a duplicate job ID on saving a new job. Related to #28189.

image

Checklist

@peteharverson peteharverson added bug Fixes for quality problems that affect the customer experience review non-issue Indicates to automation that a pull request should not appear in the release notes v7.0.0 :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 v7.2.0 v6.7.1 v6.6.2 labels Feb 28, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@peteharverson peteharverson requested a review from a team as a code owner February 28, 2019 10:39
walterra
walterra approved these changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$scope.LGTM = true;
$scope.$applyAsync();

jgowdyelastic
jgowdyelastic approved these changes Feb 28, 2019
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

alvarezmelissa87
alvarezmelissa87 approved these changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@peteharverson peteharverson merged commit 46cc846 into elastic:master Mar 1, 2019
@peteharverson peteharverson mentioned this pull request Mar 1, 2019
Merged
@peteharverson peteharverson mentioned this pull request Mar 1, 2019
Merged
peteharverson added a commit to peteharverson/kibana that referenced this pull request Mar 1, 2019
@peteharverson
[ML] Adds missing applyAsync to advanced job wizard page (elastic#32186)
b2b91cc
peteharverson added a commit that referenced this pull request Mar 1, 2019
@peteharverson
[ML] Adds missing applyAsync to advanced job wizard page (#32186) (#3…
f0cae48 
…2290)
@peteharverson peteharverson mentioned this pull request Mar 1, 2019
Merged
peteharverson added a commit to peteharverson/kibana that referenced this pull request Mar 1, 2019
@peteharverson
[ML] Adds missing applyAsync to advanced job wizard page (elastic#32186)
870f0e1
peteharverson added a commit that referenced this pull request Mar 1, 2019
@peteharverson
[ML] Adds missing applyAsync to advanced job wizard page (#32186) (#3…
5035d13 
…2296)
@peteharverson peteharverson mentioned this pull request Mar 1, 2019
Merged
peteharverson added a commit to peteharverson/kibana that referenced this pull request Mar 1, 2019
@peteharverson
[ML] Adds missing applyAsync to advanced job wizard page (elastic#32186)
887fec8
peteharverson added a commit that referenced this pull request Mar 1, 2019
@peteharverson
[ML] Adds missing applyAsync to advanced job wizard page (#32186) (#3…
8cfa6f5 
…2297)
peteharverson added a commit to peteharverson/kibana that referenced this pull request Mar 1, 2019
@peteharverson
[ML] Adds missing applyAsync to advanced job wizard page (elastic#32186)
b0ca7bd
peteharverson added a commit that referenced this pull request Mar 4, 2019
@peteharverson
[ML] Adds missing applyAsync to advanced job wizard page (#32186) (#3…
7df869e 
…2289)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes review v6.6.2 v6.7.0 v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peteharverson @elasticmachine @walterra @alvarezmelissa87 @jgowdyelastic