[kbn-test] upgrade to babel7, add ts support #32168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
azasypkin
approved these changes
Feb 28, 2019
|
|
||
| module.exports = { | ||
| presets: ['@kbn/babel-preset/node_preset_7'], | ||
| ignore: ['**/*.test.js'], |
There was a problem hiding this comment.
question: why do we exclude JS tests?
There was a problem hiding this comment.
Because jest implements its own preset for tests, and excluding them here prevents them from being built when we build the package for use.
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Feb 28, 2019
* [babel] add babel7 compatible node preset * [kbn-test] upgrade to babel7 preset
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Feb 28, 2019
* [babel] add babel7 compatible node preset * [kbn-test] upgrade to babel7 preset
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Feb 28, 2019
* [babel] add babel7 compatible node preset * [kbn-test] upgrade to babel7 preset
spalger
pushed a commit
that referenced
this pull request
Feb 28, 2019
spalger
pushed a commit
that referenced
this pull request
Feb 28, 2019
spalger
pushed a commit
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support typescript in
@kbn/testwithout making the build process complicated, I'm upgrading to babel7, adding a babel7 compatible preset at@kbn/babel-preset/node_preset_7in the process.