Remove types from Esqueue #32146
Merged
Remove types from Esqueue #32146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
|
Pinging @elastic/kibana-operations |
|
LGTM |
joelgriffith
approved these changes
Feb 27, 2019
jbudz
approved these changes
Feb 27, 2019
joshdover
force-pushed
the
remove-types/esqueue
branch
from
0ae5578 to
19fa965
Compare
💚 Build Succeeded |
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Feb 28, 2019
This was referenced Feb 28, 2019
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Feb 28, 2019
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Feb 28, 2019
|
Realized backporting this to 6.7 doesn't make sense anymore:
|
joshdover
added a commit
that referenced
this pull request
Feb 28, 2019
joshdover
added a commit
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes the usage of types from Esqueue used for the
.reportingindex. New indices will get created with the default mapping type_docand old indices will still haveesqueue. I've removed all usages of the type completely as well as any code that was exposing the type, so the differing doc types should not matter.This work is in support of #32035 to remove any code causing
[types removal]deprecation logs in 6.7/7.x.