-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Fix formatting of values for time of day or week anomalies #32134
[ML] Fix formatting of values for time of day or week anomalies #32134
Conversation
Pinging @elastic/ml-ui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💔 Build Failed |
retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit late on this but LGTM!
Summary
Fixes the formatting of
actual
andtypical
values in the anomalies table fortime_of_day
andtime_of_week
detectors.Fixes two issues:
The values are formatted by using the timestamp of the anomaly, working in UTC, then get the start of the day / week in UTC, add on the offset value in seconds, and finally format in
HH:mm
orddd HH:mm
format using the configured Kibana timezone.Before (anomaly time is 22:00, but
actual
in table is shown as 11:02 - one hour out and 12 hour format)After (anomaly time is 22:00, and
actual
correctly displayed as 22:02)Checklist
For maintainers
Fixes #32023