[Canvas] Chore: remove exception that impairs user experience #32114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the condition is met
monfera
added
review
v7.0.0
Team:Presentation
|
Pinging @elastic/kibana-canvas |
💚 Build Succeeded |
w33ble
approved these changes
Feb 28, 2019
monfera
added a commit
to monfera/kibana
that referenced
this pull request
Mar 3, 2019
…e the condition is met (elastic#32114)
monfera
added a commit
to monfera/kibana
that referenced
this pull request
Mar 3, 2019
…e the condition is met (elastic#32114)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the alpha stage, this exception was useful to hunt down mw/thunk based issues, but such exceptions tapered off, and on the off-chance the condition ever happens, it's better to keep the page functional, while the old value gets garbage collected (layout engine state is a plain JSON-serializable object, none of its parts require a destroy method). Also, the ongoing refactoring removes this Map altogether.