Fix percentiles for table in TSVB #32084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
💚 Build Succeeded |
markov00
approved these changes
Feb 28, 2019
There was a problem hiding this comment.
Code LGTM. Tested locally and works correctly.
I've just a minor concern on field without any label on the percentile: maybe we need to add a place holder or better a label, it feels a bit lonely there all alone :)
@AlonaNadler what do you think?
|
LGTM |
sulemanof
added a commit
to sulemanof/kibana
that referenced
this pull request
Mar 1, 2019
* Fix percentiles for table in TSVB * Disable add percentiles in table
sulemanof
added a commit
to sulemanof/kibana
that referenced
this pull request
Mar 1, 2019
* Fix percentiles for table in TSVB * Disable add percentiles in table
sulemanof
added a commit
that referenced
this pull request
Mar 1, 2019
timroes
added
Feature:TSVB
|
Pinging @elastic/kibana-app |
sulemanof
added a commit
that referenced
this pull request
Mar 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16916 .
Summary
Enable percentiles column for table in TSVB. Show a percentile value in a column label.
Disabled percentile mode in table.
If it were more that one percentile in a series configured (e.x. in Timeseries)
the last one will be shown for a user in a table view.