Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[optimize] url-loader use limit #32078

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Feb 26, 2019

url-loader is file loader + potential for inlining. this moves everything to url-loader with a limit of 8 kilobyte

Browsers typically have a maximum number connections. Under http 1, assets are loaded in parallel up to the connection limit. Small files are usually not a good practice, the longer a file downloads the faster the connection rate.

@jbudz jbudz added review Team:Operations Team label for Operations Team labels Feb 26, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, best I can tell this won't impact many files, just the icons we load in the field editor, but shouldn't cause any issues.

@jbudz jbudz merged commit 2dd80ba into elastic:master Feb 28, 2019
jbudz added a commit that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Operations Team label for Operations Team v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants