Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move getIndexPattern service to visualize #32060

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

lukasolson
Copy link
Member

Just moving this file into the visualize/ directory since it's a service specifically for getting index patterns from visualization objects and isn't related to the core concept of embeddables.

@lukasolson lukasolson added review Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.2.0 v7.0.1 labels Feb 26, 2019
@lukasolson lukasolson self-assigned this Feb 26, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

Copy link
Contributor

@stacey-gammon stacey-gammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on passing ci, code review only

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@lukasolson lukasolson merged commit d0fb7b8 into elastic:master Feb 27, 2019
lukasolson added a commit to lukasolson/kibana that referenced this pull request Feb 27, 2019
@lukasolson lukasolson removed the v7.0.1 label Feb 27, 2019
@lukasolson
Copy link
Member Author

7.x: 247cc17

@timroes timroes added the chore label Mar 27, 2019
@lukasolson lukasolson deleted the moveGetIndexPattern branch December 2, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore review Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants