[ML] Fixes restoring table interval selection from appState. #32056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
bug
|
Pinging @elastic/ml-ui |
💚 Build Succeeded |
walterra
requested review from
jgowdyelastic,
peteharverson and
alvarezmelissa87
💔 Build Failed |
jgowdyelastic
approved these changes
Feb 26, 2019
...plugins/ml/public/components/controls/select_interval/__tests__/select_interval_directive.js
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Feb 27, 2019
…#32056) Fixes a regression introduced in elastic#31692. The table interval selection wasn't properly restored from `AppState` because of a mismatch in the expected object structure.
walterra
added a commit
that referenced
this pull request
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression introduced in #31692. The table interval selection wasn't properly restored from
AppStatebecause of a mismatch in the expected object structure.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibility