Removes sinon from saved objects unit tests. #32045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
mikecote
approved these changes
Feb 26, 2019
| Promise.resolve({ | ||
| items: [], | ||
| }) | ||
| ); |
There was a problem hiding this comment.
nit: There's a shorter alternative you can do throughout, jest.fn().mockResolvedValue({ items: [] })
src/legacy/server/saved_objects/migrations/core/elastic_index.test.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
njd5475
added a commit
to njd5475/kibana
that referenced
this pull request
Feb 27, 2019
* Removes sinon from saved objects unit tests. * Uses mockResolvedValue for return values as promises.
njd5475
added a commit
to njd5475/kibana
that referenced
this pull request
Feb 27, 2019
* Removes sinon from saved objects unit tests. * Uses mockResolvedValue for return values as promises.
njd5475
added a commit
that referenced
this pull request
Feb 28, 2019
njd5475
added a commit
that referenced
this pull request
Feb 28, 2019
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Feb 28, 2019
* udpate jest, jest-cli, @types/jest to v24 * fix type error in kibana-i18n package * return serivce explicitly to fix typings * add explicit never * suppress typings errors * update jest versions in x-pack * make tests in x-pack more robust and fix incompatibility * suppress CallCluster mock typings Mock interface doesn't match CallCluster. Requires additional work * x-pack. resolve other typing conflicts * remove unused types/jest * fix snapshots * restore mocks after jest.spyOn * remove outdated definitions for jest * cleanup x-pack package.json and update @types/jest * fix tests merged from master * updated yarn.lock and log errors for scripts/type_check * This commit fixes error in TS, which failed on parsing the file. * suppress type errors from master * jest-cli is devDep Removes sinon from saved objects unit tests. (elastic#32045) (elastic#32151) * Removes sinon from saved objects unit tests. * Uses mockResolvedValue for return values as promises. temp
mshustov
added a commit
that referenced
this pull request
Feb 28, 2019
* udpate jest, jest-cli, @types/jest to v24 * fix type error in kibana-i18n package * return serivce explicitly to fix typings * add explicit never * suppress typings errors * update jest versions in x-pack * make tests in x-pack more robust and fix incompatibility * suppress CallCluster mock typings Mock interface doesn't match CallCluster. Requires additional work * x-pack. resolve other typing conflicts * remove unused types/jest * fix snapshots * restore mocks after jest.spyOn * remove outdated definitions for jest * cleanup x-pack package.json and update @types/jest * fix tests merged from master * updated yarn.lock and log errors for scripts/type_check * This commit fixes error in TS, which failed on parsing the file. * suppress type errors from master * jest-cli is devDep Removes sinon from saved objects unit tests. (#32045) (#32151) * Removes sinon from saved objects unit tests. * Uses mockResolvedValue for return values as promises. temp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jest mocking offers compatible feature set to sinon. Even though some of the
sinonconventions might be preferred, it is in our best interest to use jest as there is really no need for mixing tests with jest mocking and sinon.