Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @babel/* dependencies. #32031

Merged
merged 2 commits into from
Feb 27, 2019

Conversation

azasypkin
Copy link
Member

@azasypkin azasypkin commented Feb 26, 2019

Motivation: Babel has fixed several issues in their TS plugin that allows us to not exclude TS files with some specific syntax from i18n check that relies on babel/parser and friends.

Dev Docs

Upgrade @babel/* dependencies

Updated Babel dependencies as babel has fixed several issues in their TS plugin that allows us to not exclude TS files with some specific syntax from i18n_check that relies on babel/parser and friends.

@azasypkin azasypkin added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team v7.2.0 labels Feb 26, 2019
@azasypkin azasypkin requested review from mistic and Bamieh February 26, 2019 14:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 so excited for us to upgrade to babel 7 across the project

@elasticmachine

This comment has been minimized.

Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistic
Copy link
Member

mistic commented Feb 26, 2019

@azasypkin it looks like eslint task is failing

@azasypkin
Copy link
Member Author

@azasypkin it looks like eslint task is failing

Yep, surprisingly fresh yarn.lock solves this issue, so I'm trying to figure what dependency exactly is the culprit.

@spalger
Copy link
Contributor

spalger commented Feb 26, 2019

Might be easier to try an eslint related packages upgrade first?

@azasypkin
Copy link
Member Author

azasypkin commented Feb 27, 2019

Might be easier to try an eslint related packages upgrade first?

I tried that too, but still same error, investigating... There is likely something weird in our yarn.lock or the way I updated dependencies.

@mistic
Copy link
Member

mistic commented Feb 27, 2019

@azasypkin I would suggest one thing we can try:

  • Please upgrade everywhere @babel/traverse and @babel/types to 7.3.4 version and then on the yarn.lock try to manually delete from line

    "@babel/traverse@^7.0.0", "@babel/traverse@^7.1.0":
    to line

    kibana/yarn.lock

    Line 1004 in 3553ed0

    to-fast-properties "^2.0.0"

  • Then just re-run yarn kbn bootstrap and I think that should work

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@azasypkin
Copy link
Member Author

Thanks a lot @mistic, you changes in yarn.lock did the job!

@azasypkin azasypkin merged commit 2f62e6f into elastic:master Feb 27, 2019
@azasypkin azasypkin deleted the issue-xxx-upgrade-babel branch February 27, 2019 17:27
azasypkin added a commit to azasypkin/kibana that referenced this pull request Feb 27, 2019
@azasypkin
Copy link
Member Author

7.x/7.1.0: f850802

@epixa epixa added the release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. label May 7, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported chore release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team v7.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants