-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade @babel/* dependencies. #32031
Conversation
Pinging @elastic/kibana-operations |
Pinging @elastic/kibana-platform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 so excited for us to upgrade to babel 7 across the project
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@azasypkin it looks like eslint task is failing |
Yep, surprisingly fresh yarn.lock solves this issue, so I'm trying to figure what dependency exactly is the culprit. |
Might be easier to try an eslint related packages upgrade first? |
I tried that too, but still same error, investigating... There is likely something weird in our |
@azasypkin I would suggest one thing we can try:
|
…upgraded babel packages.
💚 Build Succeeded |
Thanks a lot @mistic, you changes in |
Co-authored-by: Tiago Costa <[email protected]>
7.x/7.1.0: f850802 |
💔 Build Failed |
💔 Build Failed |
Motivation: Babel has fixed several issues in their TS plugin that allows us to not exclude TS files with some specific syntax from i18n check that relies on babel/parser and friends.
Dev Docs
Upgrade @babel/* dependencies
Updated Babel dependencies as babel has fixed several issues in their TS plugin that allows us to not exclude TS files with some specific syntax from
i18n_check
that relies onbabel/parser
and friends.