Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unused code #32018

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Cleanup unused code #32018

merged 1 commit into from
Feb 27, 2019

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Feb 26, 2019

Summary

When I started looking into #31943 I tried to find a couple of Notifier places that we could already fix, because they are not logging errors (for which we still need some new toast notification concept, see linked issue). Unfortunately we're only having Notifier calls left with error logging. But I came across a couple of places where the variables weren't used at all anymore, so this PR will for now only remove some unused variables. See, we're even getting rid of some Promise calls :-)

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@timroes timroes added chore Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.2.0 labels Feb 26, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@timroes timroes requested a review from a team as a code owner February 26, 2019 13:22
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@kobelb kobelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security changes LGTM - thanks for taking care of this @timroes

Copy link
Contributor

@stacey-gammon stacey-gammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review only

@timroes timroes merged commit 9d77205 into elastic:master Feb 27, 2019
@timroes timroes deleted the notifier-cleanup branch February 27, 2019 09:18
timroes added a commit to timroes/kibana that referenced this pull request Feb 27, 2019
timroes added a commit that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants