Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Changing job wizard query to use match_all #32008

Merged
merged 3 commits into from
Feb 26, 2019
Merged

[ML] Changing job wizard query to use match_all #32008

merged 3 commits into from
Feb 26, 2019

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Feb 26, 2019 •
edited by droberts195
Loading

Changes the query used to draw the line charts in the wizards and used in the datafeed to be:

match_all: {}

rather than

query_string: {	   
  analyze_wildcard: true,	
  query: '*'	
}

Also removes the filters object returned from createSearchItems() but which are no longer used.
query and filters are combined to create combinedQuery which is used for every search.
query is only used in the data visualizer page as it requires a lucene query string.

Fixes #31924

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience review backport pending :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 v7.2.0 v7.0.1 labels Feb 26, 2019
@jgowdyelastic jgowdyelastic self-assigned this Feb 26, 2019
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner February 26, 2019 12:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@jgowdyelastic jgowdyelastic changed the title [ML] Using job wizard query to use match_all [ML] Changing job wizard query to use match_all Feb 26, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

peteharverson
peteharverson approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

walterra
walterra approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alvarezmelissa87
alvarezmelissa87 approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jgowdyelastic jgowdyelastic merged commit f89faec into elastic:master Feb 26, 2019
@jgowdyelastic jgowdyelastic mentioned this pull request Feb 26, 2019
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Feb 26, 2019
@jgowdyelastic
[ML] Changing job wizard query to use match_all (elastic#32008)
50edc80 
* [ML] Using job wizard query to use match_all

* adding query back in for data visualizer

* fixing typo
jgowdyelastic added a commit that referenced this pull request Feb 26, 2019
@jgowdyelastic
[ML] Changing job wizard query to use match_all (#32008) (#32048)
268fc2c 
* [ML] Using job wizard query to use match_all

* adding query back in for data visualizer

* fixing typo
@jgowdyelastic jgowdyelastic mentioned this pull request Feb 28, 2019
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Feb 28, 2019
@jgowdyelastic
[ML] Changing job wizard query to use match_all (elastic#32008)
682b918 
* [ML] Using job wizard query to use match_all

* adding query back in for data visualizer

* fixing typo
@jgowdyelastic jgowdyelastic mentioned this pull request Feb 28, 2019
Closed
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Feb 28, 2019
@jgowdyelastic
[ML] Changing job wizard query to use match_all (elastic#32008)
cce62d6 
* [ML] Using job wizard query to use match_all

* adding query back in for data visualizer

* fixing typo
jgowdyelastic added a commit that referenced this pull request Feb 28, 2019
@jgowdyelastic
[ML] Changing job wizard query to use match_all (#32008) (#32183)
1bb176d 
* [ML] Using job wizard query to use match_all

* adding query back in for data visualizer

* fixing typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@walterra walterra walterra approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml review v6.7.1 v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Change wizard's search query to use match_all
5 participants
@jgowdyelastic @elasticmachine @walterra @alvarezmelissa87 @peteharverson