fixing issues with maximum documents and maximum size being set #31998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmcconaghy
added
v7.0.0
Feature:ILM
v8.0.0
Team:Kibana Management
|
Pinging @elastic/es-ui |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
sebelga
approved these changes
Feb 26, 2019
| id={`${PHASE_HOT}-${PHASE_ROLLOVER_MAX_DOCUMENTS}`} | ||
| value={phaseData[PHASE_ROLLOVER_MAX_DOCUMENTS]} | ||
| onChange={async e => { | ||
| await setPhaseData( |
There was a problem hiding this comment.
The store/actions/policies.js that contains setPhaseData () seems to be synchronous. Do we need to await here and in other onChange handlers in this file?
There was a problem hiding this comment.
Nope, left over from a refactor, good catch.
💔 Build Failed |
|
retest |
💚 Build Succeeded |
bmcconaghy
added a commit
to bmcconaghy/kibana
that referenced
this pull request
Feb 26, 2019
…tic#31998) * fixing issues with maximum documents and maximum size being set * removing defaults from ES policy load and removing unneeded propTypes * fixing react warnings about controlled -> uncontrolled * fixing tests * more fixes for react controlled -> uncontrolled errors * better fix for react warnings through empty default phases * removing unused translation * removing unnecessary async/awaits in onChange handlers
bmcconaghy
added a commit
to bmcconaghy/kibana
that referenced
this pull request
Feb 26, 2019
…tic#31998) * fixing issues with maximum documents and maximum size being set * removing defaults from ES policy load and removing unneeded propTypes * fixing react warnings about controlled -> uncontrolled * fixing tests * more fixes for react controlled -> uncontrolled errors * better fix for react warnings through empty default phases * removing unused translation * removing unnecessary async/awaits in onChange handlers
bmcconaghy
added a commit
that referenced
this pull request
Feb 26, 2019
…) (#32039) * fixing issues with maximum documents and maximum size being set * removing defaults from ES policy load and removing unneeded propTypes * fixing react warnings about controlled -> uncontrolled * fixing tests * more fixes for react controlled -> uncontrolled errors * better fix for react warnings through empty default phases * removing unused translation * removing unnecessary async/awaits in onChange handlers
bmcconaghy
added a commit
to bmcconaghy/kibana
that referenced
this pull request
Feb 26, 2019
…tic#31998) * fixing issues with maximum documents and maximum size being set * removing defaults from ES policy load and removing unneeded propTypes * fixing react warnings about controlled -> uncontrolled * fixing tests * more fixes for react controlled -> uncontrolled errors * better fix for react warnings through empty default phases * removing unused translation * removing unnecessary async/awaits in onChange handlers
bmcconaghy
added a commit
that referenced
this pull request
Feb 26, 2019
…) (#32040) * fixing issues with maximum documents and maximum size being set * removing defaults from ES policy load and removing unneeded propTypes * fixing react warnings about controlled -> uncontrolled * fixing tests * more fixes for react controlled -> uncontrolled errors * better fix for react warnings through empty default phases * removing unused translation * removing unnecessary async/awaits in onChange handlers
bmcconaghy
added a commit
that referenced
this pull request
Feb 26, 2019
…) (#32041) * fixing issues with maximum documents and maximum size being set * removing defaults from ES policy load and removing unneeded propTypes * fixing react warnings about controlled -> uncontrolled * fixing tests * more fixes for react controlled -> uncontrolled errors * better fix for react warnings through empty default phases * removing unused translation * removing unnecessary async/awaits in onChange handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31997
This PR fixes a few issues with ILM UI and max_size/max_docs including: