fix: bump max payload size up to 25MB #31974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
default of 1MB is very easy to hit, so it's not hard to make Canvas fail
w33ble
added
review
v7.0.0
Team:Presentation
|
Pinging @elastic/kibana-canvas |
w33ble
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
monfera
approved these changes
Feb 26, 2019
monfera
pushed a commit
to monfera/kibana
that referenced
this pull request
Feb 27, 2019
default of 1MB is very easy to hit, so it's not hard to make Canvas fail
monfera
pushed a commit
to monfera/kibana
that referenced
this pull request
Feb 27, 2019
default of 1MB is very easy to hit, so it's not hard to make Canvas fail
monfera
pushed a commit
to monfera/kibana
that referenced
this pull request
Feb 27, 2019
default of 1MB is very easy to hit, so it's not hard to make Canvas fail
monfera
added a commit
that referenced
this pull request
Feb 27, 2019
monfera
added a commit
that referenced
this pull request
Feb 27, 2019
monfera
added a commit
that referenced
this pull request
Feb 27, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the max payload size for the batching interpreter route up to 25MB. The default of 1MB is very easy to hit, so it's not hard to make Canvas fail, and 25MB is the limit we've set for the entire workpad, so it's definitely an absolute maximum there too.
Fixes an issue @monfera was seeing today where he was getting
POST http://localhost:5601/s/awesome-space/api/canvas/fns 413 (Payload Too Large)on a very small workpad.These settings used to be under
config, but based on the hapijs docs, it's alloptionsnow.