-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes data points on maps not showing up in reports #31949
Fixes data points on maps not showing up in reports #31949
Conversation
💔 Build Failed |
@@ -121,8 +124,11 @@ visualize-app .visEditor__canvas { | |||
* to handle this fine, but firefox moves the visualizations around. | |||
*/ | |||
dashboard-app .react-grid-item { | |||
height: 0 !important; /* 1. */ | |||
width: 0 !important; /* 1. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing these makes the above block-level comment outdated.
It looks like it already was outdated though, as there is no server/lib/screenshot file anymore. I am not sure what "can only use the properties that will be manually set..." means
So, it turns out waiting a bit to inject the custom CSS allows all the items to render properly (and we don't have to touch hacky CSS stuff). |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - this solution is WAY better than adding additional hacks
💚 Build Succeeded |
Will work on backporting this |
@joelgriffith looks like this did not get backported to 7.x |
Maps didn't like rendering into a parent with a 0 width/height, so I went with a more granular approach of explicitly hiding certain css properties vs the width/height hack. I've attached some before/after PDF's that highlight the fix and some subtle differences.
After.pdf
Uploading Before.pdf…