Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused testbed directory in watcher #31917

Merged
merged 1 commit into from
Feb 25, 2019
Merged

remove unused testbed directory in watcher #31917

merged 1 commit into from
Feb 25, 2019

Conversation

alisonelizabeth
Copy link
Contributor

As discussed with @cjcenizal last week, this PR removes the testbed directory that is not being used in the watcher plugin.

@alisonelizabeth alisonelizabeth added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Feb 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

bmcconaghy
bmcconaghy approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure what the point of this stuff ever was :-)

@elasticmachine
Copy link
Contributor

💔 Build Failed

@alisonelizabeth
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

cjcenizal
cjcenizal approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alisonelizabeth alisonelizabeth merged commit f679dd4 into elastic:master Feb 25, 2019
@alisonelizabeth alisonelizabeth deleted the remove-testbed-dir branch February 25, 2019 17:11
@alisonelizabeth alisonelizabeth mentioned this pull request Feb 25, 2019
Merged
alisonelizabeth added a commit to alisonelizabeth/kibana that referenced this pull request Feb 25, 2019
@alisonelizabeth
remove unused testbed directory in watcher (elastic#31917)
666717e
alisonelizabeth added a commit that referenced this pull request Feb 25, 2019
@alisonelizabeth
remove unused testbed directory in watcher (#31917) (#31929)
d1acfe5
@cjcenizal cjcenizal added the non-issue Indicates to automation that a pull request should not appear in the release notes label May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmcconaghy bmcconaghy bmcconaghy approved these changes

@cjcenizal cjcenizal cjcenizal approved these changes

Assignees

@cjcenizal cjcenizal

@bmcconaghy bmcconaghy

Labels
Feature:Watcher non-issue Indicates to automation that a pull request should not appear in the release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alisonelizabeth @elasticmachine @cjcenizal @bmcconaghy