Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clearing number of replicas from existing policy #31905

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

bmcconaghy
Copy link
Contributor

Resolves #31443

This change fixes a bug where the user couldn't clear out the number of replicas from an ILM policy once they were defined for a phase. To test, create an ILM policy with the Number of Replicas set for a phase, then edit it and clear that value out and save. The field should be empty when you edit it again.

@bmcconaghy bmcconaghy added v7.0.0 Feature:ILM v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v6.7.0 v7.2.0 labels Feb 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and LGTM!

@bmcconaghy bmcconaghy merged commit ae72315 into elastic:master Feb 25, 2019
@bmcconaghy bmcconaghy deleted the fix_clear_num_replicas_ilm branch February 25, 2019 14:54
bmcconaghy added a commit to bmcconaghy/kibana that referenced this pull request Feb 25, 2019
bmcconaghy added a commit to bmcconaghy/kibana that referenced this pull request Feb 25, 2019
bmcconaghy added a commit to bmcconaghy/kibana that referenced this pull request Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ILM Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v6.7.0 v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ILM] Number of replicas cannot be cleared
3 participants