Fix/vislib click error #31896
Merged
Fix/vislib click error #31896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisljar
added
review
v7.0.0
Team:Visualizations
|
Pinging @elastic/kibana-app |
💚 Build Succeeded |
flash1293
approved these changes
Feb 25, 2019
| d3.event.target.nearestViewportElement.__data__ : d3.event.target.__data__; | ||
| const isSlices = !!(_data && _data.slices); | ||
| clickEventResponse(d, props = {}) { | ||
| let isSlices = props.isSlices; |
There was a problem hiding this comment.
Is this just for testing to avoid mocking d3 here? If yes, the JSdoc of the function could be updated to reflect this.
There was a problem hiding this comment.
yes ... well it would be nice if we wouldn't use that d3 magic at all, but removing it would take much more time i guess
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Feb 26, 2019
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Feb 26, 2019
ppisljar
added a commit
that referenced
this pull request
Feb 26, 2019
ppisljar
added a commit
that referenced
this pull request
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
resolves #31409
resolves #31519
fixes crash on clicking pie/bar with count agg only
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately