[Maps] render attribution with no url as text instead of EuiLink #31873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
v7.0.0
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis |
💔 Build Failed |
💚 Build Succeeded |
thomasneirynck
approved these changes
Feb 24, 2019
| @@ -63,11 +62,21 @@ export class AttributionControl extends React.Component { | |||
| } | |||
| }; | |||
|
|
|||
| _renderAttribution({ url, label }) { | |||
| if (!url || url.length === 0) { | |||
There was a problem hiding this comment.
url.length === 0 is redundant I think
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Feb 25, 2019
…stic#31873) * [Maps] render attribution with no url as text instead of EuiLink * remove check for length
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Feb 25, 2019
…stic#31873) * [Maps] render attribution with no url as text instead of EuiLink * remove check for length
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Feb 25, 2019
…stic#31873) * [Maps] render attribution with no url as text instead of EuiLink * remove check for length
nreese
added a commit
that referenced
this pull request
Feb 25, 2019
) (#31900) * [Maps] render attribution with no url as text instead of EuiLink * remove check for length
nreese
added a commit
that referenced
this pull request
Feb 25, 2019
) (#31898) * [Maps] render attribution with no url as text instead of EuiLink * remove check for length
nreese
added a commit
that referenced
this pull request
Feb 25, 2019
) (#31899) * [Maps] render attribution with no url as text instead of EuiLink * remove check for length
nreese
added
non-issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #31747