[Canvas] Fixes filter clearing on undo/redo

[cqliu1]

Summary

Closes #28730.

This adds a check in the setExpression action to clear out the filters if the expression is no longer a filter expression. This makes sure filters don't persist if you started with a filter element and changed the expression to another type of element, such as markdown.

This also removes the call to clear element filters from the filter element onDestroy handler which was clearing out the element's filter when you undo/redo or nav between workpad pages.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately
• This includes a feature addition or change that requires a release note and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-canvas

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[w33ble]

Is there a way we can get the list of filter elements without hard-coding them here? Maybe we can pull the functions from the registry somehow?

[cqliu1]

I'd need to somehow check for render functions that specifically render filters. I don't see anything in the renderer def that I could use to single out filter renderers.

I could introduce a new property in the renderer def like subtype: filter, but I think this should be addressed in a separate PR.

[w33ble]

Yeah, I gave this some thought too, and couldn't come up with anything simple here. I'm cool derfering on this as well, just please open an issue for it.

[cqliu1]

I added a TODO to that line, and I'll open an issue.

[w33ble]

This is a ton better, but there's still an edge case here that involves the advanced filter. It may be a bug in that component though, and I'm fine with deferring and opening another issue instead.

Here's the edge case:

• load the flights workpad (reset sample data if needed)
• delete the existing time filter (this makes it easier to watch the values in state)
• add new time filter (now you can just watch the last element in the list)
• change field to "timestamp"

So far so good, we see the filter value we expect to see. Now:

• change expression to timefilterControl compact=true column="timestamp" | render as=advanced_filter
• look at the filter value, it shows the wrong value

Note that column is still set to the original @timestamp value, not the updated timestamp value.

If you change the filter value and click apply, and then remove the render as=advanced_filter part, the time filter does show the updated value, which is good, but it seems to get out of sync the other way.

As stated, I'm fine deferring this, advanced_filter is kind of a hidden element, it's not really documented and doesn't show up in auto-complete, so users are probably unlikely to run into this.

[w33ble]

LGTM as-is, but see my comment about the edge case. If you don't want to fix it here (which is probably the right call), please open a new issue.

[cqliu1]

@w33ble I opened #31952 for the advanced_filter issue.

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request